Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added current context view #79

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Added current context view #79

merged 4 commits into from
Aug 13, 2023

Conversation

eyal-solomon1
Copy link
Contributor

  • Added a small context identifier (was a bit confused on where it would be applied to)
Screenshot 2023-07-08 at 13 07 47

@eyal-solomon1 eyal-solomon1 mentioned this pull request Aug 3, 2023
Closed
sozercan
sozercan reviewed Aug 4, 2023
View reviewed changes
.DS_Store Outdated Show resolved Hide resolved
sozercan
sozercan reviewed Aug 4, 2023
View reviewed changes
cmd/cli/kubernetes.go Outdated
}

func getCurrentContextName() (string, error) {
var kubeConfig string = getKubeConfig()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var kubeConfig string = getKubeConfig()
kubeConfig := getKubeConfig()

sozercan
sozercan requested changes Aug 4, 2023
View reviewed changes
Copy link
Owner

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! added minor comments and please address the lint errors, otherwise LGTM

@eyal-solomon1
Copy link
Contributor Author

@sozercan fixed :)

sozercan
sozercan approved these changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit 808b008 into sozercan:main Aug 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyal-solomon1 @sozercan