fix(foundry): support session-bound brokered continuations - #20
Merged
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Foundry hosted continuations can lose custom request headers, while the public Responses gateway requires
agent_session_idin the request body to route a follow-up to the original sandbox. AgentKit previously accepted only the custom proof header and did not consume body session identity before taking the continuation branch.This could reject a legitimate Orka continuation before state lookup, or route it to state without verifying that the pending response belongs to the effective Foundry session.
Behavior
FOUNDRY_AGENT_SESSION_IDtakes precedence over body/query/header compatibility values inside the hosted containeragent_session_id; Foundry remains the owner of the public session fieldValidation
uv run --directory runtimes/common --extra dev pytest -q— 303 passedgo test ./...make lint— 0 issuesgo test ./examples/harness/foundry-responsesin the coordinated Orka worktreeScope
This is a stacked follow-up to #19. Live Foundry gateway passthrough, immediate affinity, and explicit session stop/resume evidence remain deployment validation gates; this PR does not claim multi-replica or production-grade durability.