Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Swift 5 deprecations and update dummy project #51

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix Swift 5 deprecations and update dummy project #51

merged 1 commit into from
Jan 20, 2023

Conversation

J-Mendes
Copy link
Collaborator

@J-Mendes J-Mendes commented Apr 4, 2019

Do some changes regarding Swift 5 and Xcode 10.2:

  • Fixed withUnsafeBytes/withUnsafeMutableBytes deprecation
  • Updated dummy project to swift 5 and do Xcode suggested changes

@PH9 PH9 mentioned this pull request Jun 28, 2019
Open
@brentvvosselen brentvvosselen mentioned this pull request May 20, 2020
Open
yen936
yen936 approved these changes Jan 20, 2023
View reviewed changes
Copy link

@yen936 yen936 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soyersoyer Looks good to me. Could this be merged? @brentvvosselen thinks this will solve (#59)

@soyersoyer soyersoyer merged commit 50e5267 into soyersoyer:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yen936 yen936 yen936 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@J-Mendes @yen936 @soyersoyer