Skip to content
This repository was archived by the owner on Apr 16, 2026. It is now read-only.

port: [#6577] Can you add a log line for this exception? (#6587) - #341

Closed
erquirogasw wants to merge 6 commits into
mainfrom
southworks/add/log-line-for-UnauthorizedAccessException
Closed

erquirogasw wants to merge 6 commits into
mainfrom
southworks/add/log-line-for-UnauthorizedAccessException

Conversation

@erquirogasw

@erquirogasw erquirogasw commented Feb 17, 2023 •

Copy link
Copy Markdown

#minor
Fixes # 6577

Description

This PR ports the changes in the [PR#6587](https ://github.com/microsoft/botbuilder-dotnet/pull/ 6587) to add a log in the process method of the CloudAdapter class to show more information about the exceptions.

Specific Changes

  • Added log to the process method in CloudAdapter.cs.
  • Updated process tests in CloudAdapterTests.cs.

Testing

This image shows the new unit test passing.
eJfjGifR53

@coveralls

coveralls commented Feb 17, 2023 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 4264361266

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 84.761%

Totals Coverage Status
Change from base Build 4166700540: 0.1%
Covered Lines: 20023
Relevant Lines: 22395

💛 - Coveralls

@erquirogasw
erquirogasw force-pushed the southworks/add/log-line-for-UnauthorizedAccessException branch from c82ee34 to d4894a5 Compare February 22, 2023 13:24
Comment thread libraries/botbuilder/src/cloudAdapter.ts Outdated
Comment thread libraries/botbuilder/tests/cloudAdapter.test.js
@erquirogasw

Copy link
Copy Markdown
Author

promoted /4439

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants