Skip to content

Fix: [Create Bot Page] Multiples errors related to the Name property of page elements #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luislera wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: [Create Bot Page] Multiples errors related to the Name property of page elements #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dbaf38
Updated the aria-label value to fix the error reported by the audit tool
luislera Oct 7, 2021
ba9de74
Updated the aria-label for the breadcrumb element
luislera Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/pages/design/VisualPanelHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ const VisualPanelHeader: React.FC<VisualPanelHeaderProps> = React.memo((props) =
<div css={pageStyles.visualPanelHeaderContainer}>
<div style={{ width: '85%' }}>
<Breadcrumb
ariaLabel={formatMessage('Navigation Path')}
ariaLabel={formatMessage('Breadcrumb Path')}
data-testid="Breadcrumb"
items={items}
styles={pageStyles.breadcrumbClass}
Expand Down
2 changes: 1 addition & 1 deletion Composer/packages/lib/ui-shared/src/components/IconMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export const IconMenu: React.FC<IconMenuProps> = ({
return (
<OverflowSet
vertical
aria-label="icon menu"
aria-label="more options icon"
overflowItems={menuItems}
onRenderItem={onRenderItem}
onRenderOverflowButton={onRenderOverflowButton}
Expand Down