Fixes for some RBS errors within steep gem #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes [error] Instance variable cannot have different type with parents: (::RBS::Resolver::TypeNameResolver | nil) <=> ::RBS::Resolver::TypeNameResolver
Fixes [error] Type `::Steep::Subtyping::Relation` is generic but used as a non generic type
amatsuda
commented
Nov 16, 2022
| @@ -384,11 +384,11 @@ module Steep | |||
| class IncompatibleAnnotation < Base | |||
| attr_reader result: Subtyping::Result::Base | |||
|
|
|||
| attr_reader relation: Subtyping::Relation | |||
| attr_reader relation: Subtyping::Relation[untyped] | |||
There was a problem hiding this comment.
Maybe this can be typed stricter? Tell me if so.
There was a problem hiding this comment.
It may be... I'm not sure what the type should be. 🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running
steep checkon my app, I got some errors raised from inside Steep gem. I soon learned from the documentation that I could mute these errors by addingignoreentry in my rbs_collection.yaml, but anyway it'd be better for steep not to raise when being type checked, so here are my quick fixes for two of them.I'm sorry though, I couldn't fix all the errors. I'm still seeing the following error, but I'll leave it untouched because I'm not sure what is the proper fix.