Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add diagnostics for Ruby page #1249

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

euglena1215
Copy link
Contributor

When running steep check, various errors are displayed, but there is no clear explanation of what these errors mean.

So I created a document for error reference.

Japanese version: https://tech.timee.co.jp/entry/2024/10/02/153330

Copy link
Contributor

@ParadoxV5 ParadoxV5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I needed this since years ago. 🙏

# Diagnostics for Ruby
Each error description will follow the format below.

````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````
````markdown

Comment on lines 81 to 83
| all_error | default | strict | lenient | silent |
| --- | --- | --- | --- | --- |
| error | warning | error | information | nil |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like default is between strict and lenient.

Suggested change
| all_error | default | strict | lenient | silent |
| --- | --- | --- | --- | --- |
| error | warning | error | information | nil |
| all_error | strict | default | lenient | silent |
| --- | --- | --- | --- | --- |
| error | error | warning | information | nil |

Also, I’m not sure if it’s necessary to include the all_error and silent severities, as they (should) set everything to error and nil respectively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like default is between strict and lenient.

Thanks! I'll fix it.

Also, I’m not sure if it’s necessary to include the all_error and silent severities, as they (should) set everything to error and nil respectively.

This was a point that bothered me too. I thought it would be valuable to have a list of error presets, so I'm listing them here, but I'd like to hear soutaro-san's thoughts.

When running steep check, various errors are displayed,
but there is no clear explanation of what these errors mean.

So I created a document for error reference.

Japanese version: https://tech.timee.co.jp/entry/2024/10/02/153330
@soutaro soutaro force-pushed the doc-diagnostics-for-ruby branch from 4241a59 to b67f0d7 Compare November 26, 2024 08:31
@soutaro soutaro enabled auto-merge November 26, 2024 08:34
@soutaro soutaro added this to the Steep 1.9 milestone Nov 26, 2024
@soutaro soutaro merged commit d14cde4 into soutaro:master Nov 26, 2024
17 checks passed
@soutaro soutaro added the Released The PR is already included in a published release label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants