jenkins_slave_jnlp resource creation is not compatible with Ruby3.1 #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2023 17:01
…c-18 client (ruby3.1).
Stromweld
added
the
Release: Major
|
Can you please add a CHANGELOG.md so we can release this, thanks very much 👍🏼 |
damacus
added
the
Waiting on Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
jenkins_slave_jnlpbreaks recipe run when executed on cinc-18 client (Ruby3.1).slave_jar_url method is not executed and remote_resource has no source defined.
To fix it, I just moved
slave_jar_urlevaluation outside the resource declaration scope.fileactions notify undefined service name, this breaks recipe execution.2nd commit removes runit services before starting new service