Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins repository key URLs. #808

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

nuclearsandwich
Copy link
Contributor

@nuclearsandwich nuclearsandwich commented Jun 19, 2023

Description

The repository signing keys for the Jenkins apt and rpm repositories have been rotated and the new signing keys are available at a separate URL from the previous ones.

As of 2023-06-19 the previous keys are no longer available and the URLs used prior to this patch 404 so I do not think there is an advantage to making this change conditional.

Background on the Jenkins repository change is here: https://www.jenkins.io/blog/2023/03/27/repository-signing-keys-changing/

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

The repository signing keys for the Jenkins apt and rpm repositories
have been rotated and the new signing keys are available at a separate
URL from the previous ones.

As of 2023-06-19 the previous keys are no longer available and the URLs
used prior to this patch 404 so I do not think there is an advantage to
making this change conditional.

Background on the Jenkins repository change is here: https://www.jenkins.io/blog/2023/03/27/repository-signing-keys-changing/
@@ -4,6 +4,8 @@ This file is used to list changes made in each version of the jenkins cookbook.

## Unreleased

Update Jenkins apt/rpm repository key urls.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most recent changelog entries do not use bulleted lists. I followed that although earlier entries do. Was there an explicit style change or was this a formatting discrepancy with the recent entries?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those were done via automated PRs which don't know about the bullets. Please add a bullet here and try and fix the formatting of the others if you can.

@nuclearsandwich nuclearsandwich marked this pull request as ready for review June 29, 2023 16:30
@nuclearsandwich nuclearsandwich requested a review from a team as a code owner June 29, 2023 16:30
@nuclearsandwich
Copy link
Contributor Author

CI blocked re-running integration tests because of broken links to tickets.chef.io in the changelog (although these links were added in much earlier entries).

I don't think that it makes sense to disable link checking completely or to allow the markdown check to fail every time the changelog is touched. Can we ignore those specific urls somehow?

It seems like the markdown-link-check supports a json config file but I don't know if adding one here would be properly plumbed through the lint-unit workflow without making changes there. https://github.com/sous-chefs/.github/blob/main/.github/workflows/lint-unit.yml

@ramereth
Copy link
Contributor

@nuclearsandwich broken links should be fixed or just removed. I have been removing those links in other CHANGELOG's too and I think the same should be the case here.

@@ -4,6 +4,8 @@ This file is used to list changes made in each version of the jenkins cookbook.

## Unreleased

Update Jenkins apt/rpm repository key urls.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those were done via automated PRs which don't know about the bullets. Please add a bullet here and try and fix the formatting of the others if you can.

@ramereth ramereth added the Release: Patch Release to Chef Supermarket as a version patch when merged label Jun 30, 2023
@nuclearsandwich
Copy link
Contributor Author

Thanks for the feedback! Changelog fixes proposed in #809 after which I'll rebase this to include those changes.

xorima
xorima previously approved these changes Sep 28, 2023
@damacus damacus merged commit 68c133a into main Oct 3, 2023
@damacus damacus deleted the nuclearsandwich/jenkins-2023-repo-key branch October 3, 2023 15:25
@kitchen-porter
Copy link
Contributor

Released as: 9.5.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release: Patch Release to Chef Supermarket as a version patch when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants