-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jenkins repository key URLs. #808
Conversation
The repository signing keys for the Jenkins apt and rpm repositories have been rotated and the new signing keys are available at a separate URL from the previous ones. As of 2023-06-19 the previous keys are no longer available and the URLs used prior to this patch 404 so I do not think there is an advantage to making this change conditional. Background on the Jenkins repository change is here: https://www.jenkins.io/blog/2023/03/27/repository-signing-keys-changing/
@@ -4,6 +4,8 @@ This file is used to list changes made in each version of the jenkins cookbook. | |||
|
|||
## Unreleased | |||
|
|||
Update Jenkins apt/rpm repository key urls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most recent changelog entries do not use bulleted lists. I followed that although earlier entries do. Was there an explicit style change or was this a formatting discrepancy with the recent entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were done via automated PRs which don't know about the bullets. Please add a bullet here and try and fix the formatting of the others if you can.
CI blocked re-running integration tests because of broken links to tickets.chef.io in the changelog (although these links were added in much earlier entries). I don't think that it makes sense to disable link checking completely or to allow the markdown check to fail every time the changelog is touched. Can we ignore those specific urls somehow? It seems like the markdown-link-check supports a json config file but I don't know if adding one here would be properly plumbed through the lint-unit workflow without making changes there. https://github.com/sous-chefs/.github/blob/main/.github/workflows/lint-unit.yml |
@nuclearsandwich broken links should be fixed or just removed. I have been removing those links in other CHANGELOG's too and I think the same should be the case here. |
@@ -4,6 +4,8 @@ This file is used to list changes made in each version of the jenkins cookbook. | |||
|
|||
## Unreleased | |||
|
|||
Update Jenkins apt/rpm repository key urls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those were done via automated PRs which don't know about the bullets. Please add a bullet here and try and fix the formatting of the others if you can.
Thanks for the feedback! Changelog fixes proposed in #809 after which I'll rebase this to include those changes. |
Released as: 9.5.19 |
Description
The repository signing keys for the Jenkins apt and rpm repositories have been rotated and the new signing keys are available at a separate URL from the previous ones.
As of 2023-06-19 the previous keys are no longer available and the URLs used prior to this patch 404 so I do not think there is an advantage to making this change conditional.
Background on the Jenkins repository change is here: https://www.jenkins.io/blog/2023/03/27/repository-signing-keys-changing/
Check List
## Unreleased
New functionality includes testing.New functionality has been documented in the README if applicable.