fix: handle gen2 ios pen race condition #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and rendering of frozen images in the
RNSketchCanvas
component, particularly addressing the management of translucent paths and ensuring images are up-to-date before rendering. The changes enhance memory management and prevent potential crashes or rendering issues when working with frozen and translucent images.Improvements to frozen image management and rendering:
ensureFrozenImagesUpToDate
to make sure that frozen images (_frozenImage
and_translucentFrozenImage
) are created and current before image rendering operations. This method is now called at the start ofcreateImageWithTransparentBackground
. [1] [2]setFrozenImageNeedsUpdate
by only releasing and nullifying_frozenImage
and_translucentFrozenImage
if they are non-nil, preventing double-releases and potential crashes.Enhancements to image rendering logic:
_frozenImage
and_translucentFrozenImage
before drawing them, and only draw_translucentFrozenImage
if the current path is translucent. This prevents unnecessary or incorrect image draws. [1] [2]