Skip to content

Conversation

truittjanney
Copy link

My changes:

removed old android manifest
removed RNSketchCanvasViewManager
removed conditional logic in build.gradle
updated readme

Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you attach videos of working example app (iOS/Android) with these changes? Pretty low level changes so we need to be sure they work.

@truittjanney truittjanney reopened this Sep 2, 2025
@truittjanney
Copy link
Author

untitled.webm

Here is me testing inside the Android emulator. Let me know if there is anything in the video that is missing or if there is a particular way you like the demos to be.

@iBotPeaches
Copy link
Member

Here is me testing inside the Android emulator. Let me know if there is anything in the video that is missing or if there is a particular way you like the demos to be.

Looks solid - lets confirm iOS

@truittjanney
Copy link
Author

iOS working!

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-09-02.at.16.30.05.mp4

@iBotPeaches iBotPeaches requested a review from ian-wd September 2, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants