Skip to content

React19 + Typescript fixes #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

React19 + Typescript fixes #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7402bcf
chore: avoid using deprecated global `JSX` and properly import type
ian-wd May 28, 2025
5824806
fix: react 19 `implicit-ref-callback-return` typescript error
ian-wd May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@

_renderItem = ({ item, index }: { item: any; index: any }) => (
<TouchableOpacity
style={{ marginHorizontal: 2.5 }}

Check warning on line 187 in src/index.tsx

View workflow job for this annotation

GitHub Actions / Lint and Tests 

Inline style: { marginHorizontal: 2.5 }
onPress={() => {
if (this.state.color === item.color) {
// eslint-disable-next-line @typescript-eslint/no-shadow
Expand Down Expand Up @@ -227,9 +227,9 @@
render() {
return (
<View style={this.props.containerStyle}>
<View style={{ flexDirection: 'row' }}>

Check warning on line 230 in src/index.tsx

View workflow job for this annotation

GitHub Actions / Lint and Tests 

Inline style: { flexDirection: 'row' }
<View
style={{

Check warning on line 232 in src/index.tsx

View workflow job for this annotation

GitHub Actions / Lint and Tests 

Inline style: { flexDirection: 'row', flex: 1, justifyContent: 'flex-start' }
flexDirection: 'row',
flex: 1,
justifyContent: 'flex-start',
Expand All @@ -256,7 +256,7 @@
)}
</View>
<View
style={{

Check warning on line 259 in src/index.tsx

View workflow job for this annotation

GitHub Actions / Lint and Tests 

Inline style: { flexDirection: 'row', flex: 1, justifyContent: 'flex-end' }
flexDirection: 'row',
flex: 1,
justifyContent: 'flex-end',
Expand Down Expand Up @@ -305,7 +305,9 @@
</View>
</View>
<SketchCanvas
ref={(ref) => (this._sketchCanvas = ref)}
ref={(ref) => {
this._sketchCanvas = ref;
}}
style={this.props.canvasStyle}
strokeColor={
this.state.color +
Expand All @@ -326,7 +328,7 @@
permissionDialogTitle={this.props.permissionDialogTitle}
permissionDialogMessage={this.props.permissionDialogMessage}
/>
<View style={{ flexDirection: 'row' }}>

Check warning on line 331 in src/index.tsx

View workflow job for this annotation

GitHub Actions / Lint and Tests 

Inline style: { flexDirection: 'row' }
<FlatList
data={this.props.strokeColors}
extraData={this.state}
Expand Down
1 change: 1 addition & 0 deletions src/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { JSX } from 'react';
import type { StyleProp, ViewStyle } from 'react-native';

export type ImageType = 'png' | 'jpg';
Expand Down