Skip to content

Upgrade example to RN 72.x #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2023
Merged

Upgrade example to RN 72.x #64

merged 4 commits into from
Aug 2, 2023

Conversation

ian-wd
Copy link
Contributor

@ian-wd ian-wd commented Aug 1, 2023

No description provided.

@ian-wd ian-wd requested a review from iBotPeaches August 1, 2023 09:00
@iBotPeaches iBotPeaches changed the title Bump react native version Upgrade example to RN 72.x Aug 2, 2023
iBotPeaches
iBotPeaches approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@iBotPeaches iBotPeaches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on iPhone 13 Mini & Galaxy A13 5G. Some things to lodge:

  • build.gradle overrides are confusing
  • you don't need key for MRZ parser on iOS
  • if you do "combined" search, iOS won't work - it fails to detect that

@iBotPeaches iBotPeaches requested a review from jyann August 2, 2023 17:09
@iBotPeaches iBotPeaches merged commit ba64dc9 into master Aug 2, 2023
@iBotPeaches iBotPeaches deleted the rn-upgrade branch August 2, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

@jyann jyann jyann approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ian-wd @iBotPeaches @jyann