Skip to content

perf: leverage try-with-resources statement when handling input streams #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

perf: leverage try-with-resources statement when handling input streams #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions android/src/main/java/com/rnfs2/RNFSManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,7 @@ public void exists(String filepath, Promise promise) {

@ReactMethod
public void readFile(String filepath, Promise promise) {
try {
InputStream inputStream = getInputStream(filepath);
try (InputStream inputStream = getInputStream(filepath)) {
byte[] inputData = getInputStreamBytes(inputStream);
String base64Content = Base64.encodeToString(inputData, Base64.NO_WRAP);

Expand All @@ -229,8 +228,7 @@ public void readFile(String filepath, Promise promise) {

@ReactMethod
public void read(String filepath, int length, int position, Promise promise) {
try {
InputStream inputStream = getInputStream(filepath);
try (InputStream inputStream = getInputStream(filepath)) {
byte[] buffer = new byte[length];
inputStream.skip(position);
int bytesRead = inputStream.read(buffer, 0, length);
Expand Down
Loading