-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add event tests #965
Conversation
0429541
to
b799c3e
Compare
) | ||
|
||
// This test documents undesirable behaviour which should be corrected in | ||
// https://github.com/sourcenetwork/defradb/issues/867 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked ticket has been commented on with a reference to this test
bb1e82b
to
ad92fcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Andy. Only a few things I want to go over before approving.
func assertIfExpected[T any](t *testing.T, expected immutable.Option[T], actual T) { | ||
if expected.HasValue() { | ||
assert.Equal(t, expected.Value(), actual) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: I like what the Option type brings to this kind of assertion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice I'm glad, and thanks :)
ad92fcd
to
9fb11e5
Compare
8384266
to
57dc397
Compare
57dc397
to
4391750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the changes :)
😁 Thanks for requsting them |
Relevant issue(s)
Resolves #865
Description
Adds integration tests for the public-external Events channel.