Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Rework limit node flow #767

Merged
merged 3 commits into from
Aug 31, 2022
Merged

refactor: Rework limit node flow #767

merged 3 commits into from
Aug 31, 2022

Commits on Aug 30, 2022

  1. Add tests for one-many limits

    @AndrewSisley
    AndrewSisley committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    f67cc88 View commit details
    Browse the repository at this point in the history

  2. Simplify limit logic to make use of mapper 

    Some loss of efficiency here, I think the new limit nodes will make use of the same valuesNode (so not fetching from file twice) but not sure.  The planner should be able to optimise this better in the future by using the (bigger) limitNode as the source of the smaller limit node or something similar.
    @AndrewSisley
    AndrewSisley committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    7cf6fba View commit details
    Browse the repository at this point in the history

  3. FIXUP - correct comments

    @AndrewSisley
    AndrewSisley committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    585c202 View commit details
    Browse the repository at this point in the history