-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Fix the cross-build script #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orpheuslummis
added
the
ci/build
This is issue is about the build or CI system, and the administration of it.
label
May 19, 2022
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
shahzadlone
requested changes
May 24, 2022
Perhaps a better title? |
orpheuslummis
changed the title
tools: Cross-build script working and located
tools: Fix the cross-build script
May 24, 2022
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
shahzadlone
approved these changes
May 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
shahzadlone
reviewed
May 24, 2022
orpheuslummis
added
the
action/no-benchmark
Skips the action that runs the benchmark.
label
May 24, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
A cross build scripts that works for multiple target platforms and is located in `tools/scripts`. Additionally, with this commit, the top-level `build` directory goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action/no-benchmark
Skips the action that runs the benchmark.
ci/build
This is issue is about the build or CI system, and the administration of it.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEVANT ISSUE(S)
Resolves #459
DESCRIPTION
Cross build scripts that works and is located in
tools/scripts
.HOW HAS THIS BEEN TESTED?
Ran the script with
sh
the POSIX-compliant command interpreter.CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):