Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove dead code from client package and document remaining (part 1 of many) #356

Merged
merged 27 commits into from
Apr 14, 2022

Commits on Apr 13, 2022

  1. Configuration menu
    Copy the full SHA
    9ed3450 View commit details
    Browse the repository at this point in the history
  2. Extract errors to own file

    We should declare all our public errors here
    AndrewSisley committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    090c608 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dabd228 View commit details
    Browse the repository at this point in the history
  4. Declare ErrDocumentNotFound error

    No good declaring it internally if it is publicly accessable
    AndrewSisley committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    638b94b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7ec89f6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9359a02 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    55a5013 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    be16ef9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fbc9197 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Configuration menu
    Copy the full SHA
    fc8db66 View commit details
    Browse the repository at this point in the history
  2. Remove Undef DocKey

    I cant spot anywhere where we would want users to provide one of these, and don't want to encourage it
    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b8535bd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2042ec6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7a281af View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    640e8e5 View commit details
    Browse the repository at this point in the history
  6. Move DB interface to own file

    core.go is ambiguous with the newer types added to the package, and this file will get hard to read once documention expands the line count
    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    96091f3 View commit details
    Browse the repository at this point in the history
  7. Rename core.go to collection.go

    Having moved the DB interface out, this name makes sense
    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    3e30f9f View commit details
    Browse the repository at this point in the history
  8. Remove unimplemented CreateIndex function from public interface

    This function is unlikely to be implemented for quite a while and as it modifies an existing collection, it comes with a load of synchronization questions that should be answered properly before we can assume it will exist in the currently declared form
    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    3097876 View commit details
    Browse the repository at this point in the history
  9. Return result from UpdateWith

    Note: this function is untested
    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    48cc0e4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    92b0c1a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5114080 View commit details
    Browse the repository at this point in the history
  12. Document CType consts

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6b66960 View commit details
    Browse the repository at this point in the history
  13. Document errors

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6576ff6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0cb2e19 View commit details
    Browse the repository at this point in the history
  15. Document DocKeysResult

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    19b6950 View commit details
    Browse the repository at this point in the history
  16. Document UpdateResult

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6d8ce26 View commit details
    Browse the repository at this point in the history
  17. Document DeleteResult

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    2140f4d View commit details
    Browse the repository at this point in the history
  18. Tweak error messages

    AndrewSisley committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b6c58bf View commit details
    Browse the repository at this point in the history