-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove dead code from client package and document remaining (part 1 of many) #356
Merged
Commits on Apr 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9ed3450 - Browse repository at this point
Copy the full SHA 9ed3450View commit details -
We should declare all our public errors here
Configuration menu - View commit details
-
Copy full SHA for 090c608 - Browse repository at this point
Copy the full SHA 090c608View commit details -
Configuration menu - View commit details
-
Copy full SHA for dabd228 - Browse repository at this point
Copy the full SHA dabd228View commit details -
Declare ErrDocumentNotFound error
No good declaring it internally if it is publicly accessable
Configuration menu - View commit details
-
Copy full SHA for 638b94b - Browse repository at this point
Copy the full SHA 638b94bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ec89f6 - Browse repository at this point
Copy the full SHA 7ec89f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9359a02 - Browse repository at this point
Copy the full SHA 9359a02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55a5013 - Browse repository at this point
Copy the full SHA 55a5013View commit details -
Configuration menu - View commit details
-
Copy full SHA for be16ef9 - Browse repository at this point
Copy the full SHA be16ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbc9197 - Browse repository at this point
Copy the full SHA fbc9197View commit details
Commits on Apr 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for fc8db66 - Browse repository at this point
Copy the full SHA fc8db66View commit details -
I cant spot anywhere where we would want users to provide one of these, and don't want to encourage it
Configuration menu - View commit details
-
Copy full SHA for b8535bd - Browse repository at this point
Copy the full SHA b8535bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2042ec6 - Browse repository at this point
Copy the full SHA 2042ec6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a281af - Browse repository at this point
Copy the full SHA 7a281afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 640e8e5 - Browse repository at this point
Copy the full SHA 640e8e5View commit details -
core.go is ambiguous with the newer types added to the package, and this file will get hard to read once documention expands the line count
Configuration menu - View commit details
-
Copy full SHA for 96091f3 - Browse repository at this point
Copy the full SHA 96091f3View commit details -
Rename core.go to collection.go
Having moved the DB interface out, this name makes sense
Configuration menu - View commit details
-
Copy full SHA for 3e30f9f - Browse repository at this point
Copy the full SHA 3e30f9fView commit details -
Remove unimplemented CreateIndex function from public interface
This function is unlikely to be implemented for quite a while and as it modifies an existing collection, it comes with a load of synchronization questions that should be answered properly before we can assume it will exist in the currently declared form
Configuration menu - View commit details
-
Copy full SHA for 3097876 - Browse repository at this point
Copy the full SHA 3097876View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48cc0e4 - Browse repository at this point
Copy the full SHA 48cc0e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b0c1a - Browse repository at this point
Copy the full SHA 92b0c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5114080 - Browse repository at this point
Copy the full SHA 5114080View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b66960 - Browse repository at this point
Copy the full SHA 6b66960View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6576ff6 - Browse repository at this point
Copy the full SHA 6576ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cb2e19 - Browse repository at this point
Copy the full SHA 0cb2e19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19b6950 - Browse repository at this point
Copy the full SHA 19b6950View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d8ce26 - Browse repository at this point
Copy the full SHA 6d8ce26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2140f4d - Browse repository at this point
Copy the full SHA 2140f4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6c58bf - Browse repository at this point
Copy the full SHA b6c58bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.