test: Fix refreshing of docs in change detector

[AndrewSisley]

Relevant issue(s)

Resolves #2812

Description

This fixes two issues in refreshDocuments.

• DocIndexes were not accounted for in refresh documents, this was introduced a while ago and lay hiding until recently
• Creating multiple docs in a single action was not handled

refreshDocuments is called in the second half of the change detector to populate the test document cache with docs created in the setup stage.

The hardcoding of cyrpto stuff was discussed as a problem for the change detector, however that is innocent - I think I was looking at an older CI log originally. I did manage to remove the test cyrpto stuff (#2801), but it requires cleanup and doesn't really belong in this PR.

[shahzadlone]

The change seems innocent, thanks for the fix! Approving assuming detector build will pass :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.24%. Comparing base (d73b05b) to head (c085627).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2832      +/-   ##
===========================================
+ Coverage    79.18%   79.24%   +0.06%     
===========================================
  Files          319      319              
  Lines        24256    24256              
===========================================
+ Hits         19206    19220      +14     
+ Misses        3665     3654      -11     
+ Partials      1385     1382       -3     

Flag	Coverage Δ
all-tests	79.24% <ø> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73b05b...c085627. Read the comment docs.