refactor: Remove GetPrimaryIndexDocKey from collection interface #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/collections
jsimnz
reviewed
Mar 7, 2022
net/process.go
Outdated
Comment on lines
109
to
115
| func getPrimaryIndexDocKey(c client.Collection, key core.DataStoreKey) core.DataStoreKey { | ||
| return core.DataStoreKey{ | ||
| CollectionId: fmt.Sprint(c.ID()), | ||
| IndexId: fmt.Sprint(c.PrimaryIndex().ID), | ||
| }.WithInstanceInfo(key) | ||
| } | ||
|
|
There was a problem hiding this comment.
same discussion form #277. These should ideally just be kept in the base package, and we can just call col.Description().GetXYZ()
There was a problem hiding this comment.
Discussed over zoom.
- Move to (internally) shared location
There was a problem hiding this comment.
Moved onto description for now
No real reason for this to be on here, and it exposes internal types
AndrewSisley
force-pushed
the
sisley/refactor/I200-client-vs-core-primary-dockey
branch
from
0b45ba4
to
907cee5
Compare
Codecov Report
@@ Coverage Diff @@
## develop #279 +/- ##
===========================================
- Coverage 62.37% 62.36% -0.02%
===========================================
Files 84 84
Lines 9245 9250 +5
===========================================
+ Hits 5767 5769 +2
- Misses 2871 2874 +3
Partials 607 607
|
AndrewSisley
deleted the
sisley/refactor/I200-client-vs-core-primary-dockey
branch
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rcenetwork#279) * Remove GetPrimaryIndexDocKey from collection interface No real reason for this to be on here, and it exposes internal types * Remove commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #200
Spotted this as quick and (hopefully) conflict-free item that could be done in parallel with the other open PRs.