Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rework client.DB to ensure interface contains only public types #277

Merged
merged 16 commits into from
Mar 11, 2022

Commits on Mar 10, 2022

  1. Rename var to collection name

    Is clearer
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    b40add3 View commit details
    Browse the repository at this point in the history
  2. Rename GetCollection=>GetCollectionByName

    Previous fn name was a bit ambigious, particularly due to the existance of GetCollectionBySchemaID, which has the same method signature.
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    13e44c1 View commit details
    Browse the repository at this point in the history
  3. Remove schemaManager from DB interface

    Exposes a large amount of internal generator types and is not nice on a public interface
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    a42645e View commit details
    Browse the repository at this point in the history
  4. Use internal multistore instead of public fn

    Pub fn is an oddity that might be removed, this is one of two refs to it
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    8d69a88 View commit details
    Browse the repository at this point in the history
  5. Use blockstore over dagstore for public interfaces

    Removes the defra-only DagStore type/name from the db interface - blockstore concept appears to be larger than defra, and there seems no sensible way to remove it from the interfaces (p2p lib requires one).  If Cid and Block should be considered standard, then blockstore should be too.
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    7a36c25 View commit details
    Browse the repository at this point in the history
  6. Remove printDebugDb

    Is a duplicate of the public PrintDump
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    5d6867e View commit details
    Browse the repository at this point in the history
  7. Remove public XYZStore accessors

    None of these need to be public.  Leaves us with the (standard-typed, standard-concept) Root and Block stores only.
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    5234a84 View commit details
    Browse the repository at this point in the history
  8. Move store and txn interfaces into client

    txn is dependent on store, and txn is on the public db+collection interfaces
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    2cd6932 View commit details
    Browse the repository at this point in the history
  9. Reorder the DB interface

    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    703f98e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1566645 View commit details
    Browse the repository at this point in the history
  11. Remove schema from document

    Is not used, and creates extra dependency headaches when moving public items into client package.
    AndrewSisley committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    aab419a View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    121e65a View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. Configuration menu
    Copy the full SHA
    111ce4a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    785061c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b81b076 View commit details
    Browse the repository at this point in the history
  4. Remove unwanted comment

    AndrewSisley committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    958c2e7 View commit details
    Browse the repository at this point in the history