Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(i): Fix dataless compound relational index filter tests #2581

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented May 2, 2024

Relevant issue(s)

Resolves #2580

Description

Fix dataless compound relational index filter tests.

Spotted by @islamaliev here: https://github.com/sourcenetwork/defradb/pull/2575/files#r1587833621

@AndrewSisley AndrewSisley added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 2, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.11 milestone May 2, 2024
@AndrewSisley AndrewSisley requested a review from a team May 2, 2024 15:31
@AndrewSisley AndrewSisley self-assigned this May 2, 2024
Copy-paste mistake introduced by me caught shortly after merge by Islam (thanks :))
@AndrewSisley AndrewSisley force-pushed the 2580-compound-index-filter-test-copy-pasta branch from 0be8815 to c18d23e Compare May 2, 2024 15:59
Copy link
Member

@nasdf nasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit e7934b7 into sourcenetwork:develop May 2, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy-paste issue in compound index filter tests
2 participants