-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Concurrency control of Document using RWMutex #213
Conversation
closes #7 |
Codecov Report
@@ Coverage Diff @@
## develop #213 +/- ##
===========================================
+ Coverage 58.57% 58.64% +0.07%
===========================================
Files 103 103
Lines 9846 9864 +18
===========================================
+ Hits 5767 5785 +18
Misses 3449 3449
Partials 630 630
|
f0fc936
to
dfea1aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think this is still slightly incorrect - see comment on Key()
Didn't spot a difference in running benchmarks cold,hot develop vs cold,hot this branch |
dfea1aa
to
30926eb
Compare
30926eb
to
beb2694
Compare
(latest force-push is just a conflict-free rebase of the same thing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough. LGTM
Inclusion of a reader/writer mutual exclusion lock on Document and its set operation.
Inclusion of a reader/writer mutual exclusion lock on Document and its set operation.
Inclusion of a reader/writer mutual exclusion lock on
Document
and itsset
operation.Submitting as draft PR as to obtain feedback first, then iterate & submit as normal PR.