Issue 17: Convert ds key to core key #18
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly aggressive conversion of as many ds.Key references as I could to core.Key - including in files operating on the underlying datastores. This is partly because I'm assuming that the cost of core.Key{Key: foo} and core.Key.ToDS() is pretty minimal, and partly because I'm hoping to change core.Key into a more descriptive/safe set of types.
Feel very free to wait on the completion of the core.Key type change before reviewing if you think that this might have a notable negative effect on performance (or if you prefer a few more ds.Key refs for whatever reason).