Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix flaky TestCloseThroughContext test #1265

Merged
merged 3 commits into from
Mar 31, 2023
Merged

test: Fix flaky TestCloseThroughContext test #1265

merged 3 commits into from
Mar 31, 2023

Commits on Mar 31, 2023

  1. Add sleep to allow cancel to close the db

    @AndrewSisley
    AndrewSisley committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    55e1bb0 View commit details
    Browse the repository at this point in the history

  2. Remove read from chan 

    The only impact it had on the test was to slightly delay things before calling s.Close making the test a little less flaky.
    @AndrewSisley
    AndrewSisley committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    a5abd9d View commit details
    Browse the repository at this point in the history

  3. PR FIXUP - Move close of closing chan to within lock 

    Also removed the Do as it becomes pointless on this side of the lock.
    @AndrewSisley
    AndrewSisley committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    737f291 View commit details
    Browse the repository at this point in the history