Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore prefix is leaking into DB #943

Closed
jsimnz opened this issue Nov 15, 2022 · 0 comments · Fixed by #944
Closed

Datastore prefix is leaking into DB #943

jsimnz opened this issue Nov 15, 2022 · 0 comments · Fixed by #944
Labels
area/db-system Related to the core system related components of the DB bug Something isn't working

Comments

@jsimnz
Copy link
Member

jsimnz commented Nov 15, 2022

The wrapped namespace prefix which is supposed to be removed and hidden from DB is leaking into DB code.
@jsimnz jsimnz added bug Something isn't working area/db-system Related to the core system related components of the DB labels Nov 15, 2022
@jsimnz jsimnz added this to the DefraDB v0.4 milestone Nov 15, 2022
@fredcarle fredcarle mentioned this issue Nov 16, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Nov 16, 2022
@fredcarle
chore: Strip DSKey prefixes and simplify NewDataStoreKey (#944)
3e69fe6 
Relevant issue(s)
Resolves #943
Resolves #799

Description
The PR returns NewDataStoreKey to its simplest form of element indexing requiring the provided key string to be either 3 (Object Marker) or 4 elements. To accomplish this we made sure that the return datastorekey strings were stripped of prefixes.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
chore: Strip DSKey prefixes and simplify NewDataStoreKey (sourcenetwo…
428772c 
…rk#944)

Relevant issue(s)
Resolves sourcenetwork#943
Resolves sourcenetwork#799

Description
The PR returns NewDataStoreKey to its simplest form of element indexing requiring the provided key string to be either 3 (Object Marker) or 4 elements. To accomplish this we made sure that the return datastorekey strings were stripped of prefixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/db-system Related to the core system related components of the DB bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Strip DSKey prefixes and simplify NewDataStoreKey sourcenetwork/defradb
1 participant
@jsimnz