-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tool to detect database changes between branches/commits #89
Comments
Thought some more about this:
|
Had a bit of a think on this lately, and I think it should be feasible to further modify the integration tests to allow them to run across two versions, orchestrated by a controlling process (name:
Would give us a high degree of coverage for minimal effort (compared to some kind of snapshotting system). It doesn't have to be done this way, but is currently my favourite method. Would need/like to hook it up to the CI system to trigger some kind of acknowledgable warning on PR, but that could be done later if needed (running manually is better than not running). Or, on re-read of my earlier comment - integrated with a breaking-changes directory! |
…ourcenetwork#89) * Correctly set CI test environment variables Looks like the original way does not work with gotestsum (a guess, we switched over to that shortly after adding these in) * Add automatic test support for database format changes * Add database change detection step to CI
Needs to flag if anything changes between branches/commits - e.g. if the cid format changes between a feature branch and develop, or develop and master/main.
Could be done in a few ways, but need to make sure that it doesn't block the build and will not clutter up
go test ./...
. Code could live in another repo. Could be a test of go-tests dependent on an environment variable (and not run by default). Doesn't have to be written in Go, but if so check in with other team members/CTO first.Check should do something similar to:
a
(e.g. develop)Would be good to hook it up to the CI system github PRs somehow in the future, but should be considered out of scope for this issue (but don't do anything too weird that might make that overly difficult).
The text was updated successfully, but these errors were encountered: