Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make countNode explain more consistent with other nodes (sumNode) #599

Closed
shahzadlone opened this issue Jul 7, 2022 · 0 comments · Fixed by #600
Closed

Make countNode explain more consistent with other nodes (sumNode) #599

shahzadlone opened this issue Jul 7, 2022 · 0 comments · Fixed by #600
Assignees
@shahzadlone
Labels
area/query Related to the query component feature New feature or request
Milestone
DefraDB v0.3

Comments

@shahzadlone
Copy link
Member

shahzadlone commented Jul 7, 2022 •
edited
Loading

sub-task of #35

Make countNode explain more consistent with other nodes, like sumNode, specifically renaming sourceProperty to something more related to the structure after the doc structure for restructure. Something like fieldName perhaps.

Also look into if we want to or not add childFieldName.
@shahzadlone shahzadlone added feature New feature or request area/query Related to the query component labels Jul 7, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3 milestone Jul 7, 2022
@shahzadlone shahzadlone self-assigned this Jul 7, 2022
This was referenced Jul 7, 2022
Open
Merged
shahzadlone added a commit that referenced this issue Jul 9, 2022
@shahzadlone
feat: Update countNode explanation to be consistent. (#600)
16084c8 
Resolves #599 

- Description: Rename `sourceProperty` to `fieldName` to be consistent with `sumNode` and more in harmony with the post document restructure changes.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
feat: Update countNode explanation to be consistent. (sourcenetwork…
7e58d4a 
…#600)

Resolves sourcenetwork#599 

- Description: Rename `sourceProperty` to `fieldName` to be consistent with `sumNode` and more in harmony with the post document restructure changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/query Related to the query component feature New feature or request
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging a pull request may close this issue.

feat: Update countNode explanation to be consistent. sourcenetwork/defradb
1 participant
@shahzadlone