Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace interface{} with any after we bump up to v1.18 #456

Closed
shahzadlone opened this issue May 17, 2022 · 1 comment · Fixed by #805
Closed

Replace interface{} with any after we bump up to v1.18 #456

shahzadlone opened this issue May 17, 2022 · 1 comment · Fixed by #805
Assignees
@shahzadlone
Labels
code quality Related to improving code quality priority/low refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Comments

@shahzadlone
Copy link
Member

Replace interface{} with any after we bump up to Go v1.18

interface{} makes my eyes bleed.

Can I please call dibs on this :,D when it's time.
@shahzadlone shahzadlone added refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels May 17, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.4 milestone May 17, 2022
@shahzadlone shahzadlone self-assigned this May 17, 2022
@orpheuslummis
Copy link
Contributor

End of August probably

@shahzadlone shahzadlone mentioned this issue Aug 3, 2022
Closed
@shahzadlone shahzadlone mentioned this issue Sep 15, 2022
Merged
4 tasks
shahzadlone added a commit that referenced this issue Sep 16, 2022
@shahzadlone
refactor: Replace all interface{} with any alias (#805)
89c6a8f 
- Resolves: #456 
- Replace all occurrences of `interface{}` with `any` in all *.go files.
- Add linter rule to ensure `any` is always used over `interface{}`.

Command used: `find . -type f -name "*.go" -print0 | xargs -0 sed -i "s/interface{}/any/g"`
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
refactor: Replace all interface{} with any alias (sourcenetwork#805)
5882d98 
- Resolves: sourcenetwork#456 
- Replace all occurrences of `interface{}` with `any` in all *.go files.
- Add linter rule to ensure `any` is always used over `interface{}`.

Command used: `find . -type f -name "*.go" -print0 | xargs -0 sed -i "s/interface{}/any/g"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
code quality Related to improving code quality priority/low refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Replace all interface{} to any alias sourcenetwork/defradb
2 participants
@orpheuslummis @shahzadlone