Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set default schema version #1884

Closed
Tracked by #1002
AndrewSisley opened this issue Sep 15, 2023 · 0 comments · Fixed by #1888
Closed
Tracked by #1002

Allow users to set default schema version #1884

AndrewSisley opened this issue Sep 15, 2023 · 0 comments · Fixed by #1888
Assignees
@AndrewSisley
Labels
area/collections Related to the collections system area/schema Related to the schema system feature New feature or request
Milestone
DefraDB v0.8

Comments

@AndrewSisley
Copy link
Contributor

Currently we default to the head schema version, this is limiting and may often be unwanted at times - forcing stuff to update immediately upon definition.

Allow users to set the default explicitly. Consider adding a param to PatchSchema to allow users to set the default to the new one so that they dont have to make a second call.

E.g.:

PatchSchema(context.Context, string, bool)
SetDefaultSchemaVersion(context.Context, string, string)
@AndrewSisley AndrewSisley added feature New feature or request area/collections Related to the collections system labels Sep 15, 2023
@AndrewSisley AndrewSisley mentioned this issue Sep 15, 2023
Open
@AndrewSisley AndrewSisley added the area/schema Related to the schema system label Sep 15, 2023
@AndrewSisley AndrewSisley self-assigned this Sep 15, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.8 milestone Sep 15, 2023
@AndrewSisley AndrewSisley mentioned this issue Sep 15, 2023
Merged
1 task
AndrewSisley added a commit that referenced this issue Sep 25, 2023
@AndrewSisley
feat: Allow setting of default schema version (#1888)
db1f41c 
## Relevant issue(s)

Resolves #1884

## Description

Allows setting of default schema version, allowing rapid switching
between (application) api/database versions. It also allows them to
define and apply schema updates eagerly, and then make the switch at a
later date.
shahzadlone pushed a commit that referenced this issue Oct 2, 2023
@AndrewSisley @shahzadlone
feat: Allow setting of default schema version (#1888)
637eb19 
## Relevant issue(s)

Resolves #1884

## Description

Allows setting of default schema version, allowing rapid switching
between (application) api/database versions. It also allows them to
define and apply schema updates eagerly, and then make the switch at a
later date.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
feat: Allow setting of default schema version (sourcenetwork#1888)
7ab41f4 
## Relevant issue(s)

Resolves sourcenetwork#1884

## Description

Allows setting of default schema version, allowing rapid switching
between (application) api/database versions. It also allows them to
define and apply schema updates eagerly, and then make the switch at a
later date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/collections Related to the collections system area/schema Related to the schema system feature New feature or request
Projects
None yet
Milestone
DefraDB v0.8
Development

Successfully merging a pull request may close this issue.

feat: Allow setting of default schema version AndrewSisley/defradb
1 participant
@AndrewSisley