Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic using compound relational filter in top level aggregate #1869

Closed
AndrewSisley opened this issue Sep 11, 2023 · 0 comments · Fixed by #2297
Closed

Panic using compound relational filter in top level aggregate #1869

AndrewSisley opened this issue Sep 11, 2023 · 0 comments · Fixed by #2297
Assignees
@AndrewSisley
Labels
area/query Related to the query component bug Something isn't working
Milestone
DefraDB v0.10

Comments

@AndrewSisley
Copy link
Contributor

Reading the code, this may affect any relational filter in any aggregate. There also looks like there may be multiple separate code paths to achieve this flavour of bug. Top level, normal aggregate, normal aggregate where relation is also requested (this likely works, but is untested and may do other strange stuff). Be very careful with testing.

Originally discovered bug documented with TestQueryOneToOneWithCountWithCompoundOrFilterThatIncludesRelation
@AndrewSisley AndrewSisley added bug Something isn't working area/query Related to the query component labels Sep 11, 2023
This was referenced Sep 11, 2023
Closed
Merged
AndrewSisley added a commit that referenced this issue Sep 14, 2023
@AndrewSisley
test(i): Test top level agg. wt compound relational filter (#1870)
3f64bd5 
## Relevant issue(s)

Resolves #1868

## Description

Adds a test for aggregates with a compound relational filter.

Documents #1869
@AndrewSisley AndrewSisley self-assigned this Feb 8, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.10 milestone Feb 8, 2024
@AndrewSisley AndrewSisley mentioned this issue Feb 8, 2024
Merged
AndrewSisley added a commit that referenced this issue Feb 9, 2024
@AndrewSisley
fix: Fix compound relational filters in aggregates (#2297)
e28ea26 
## Relevant issue(s)

Resolves #1869

## Description

Fixes compound relational filters in aggregates where their dependencies
were not already part of the query.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
test(i): Test top level agg. wt compound relational filter (sourcenet…
47f3f63 
…work#1870)

## Relevant issue(s)

Resolves sourcenetwork#1868

## Description

Adds a test for aggregates with a compound relational filter.

Documents sourcenetwork#1869
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley
fix: Fix compound relational filters in aggregates (sourcenetwork#2297)
c5a3c13 
## Relevant issue(s)

Resolves sourcenetwork#1869

## Description

Fixes compound relational filters in aggregates where their dependencies
were not already part of the query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.10
Development

Successfully merging a pull request may close this issue.

fix: Fix compound relational filters in aggregates AndrewSisley/defradb
1 participant
@AndrewSisley