Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for allowed origins #1355

Closed
fredcarle opened this issue Apr 15, 2023 · 1 comment · Fixed by #1408
Closed

Add configuration for allowed origins #1355

fredcarle opened this issue Apr 15, 2023 · 1 comment · Fixed by #1408
Assignees
@fredcarle
Labels
area/api Related to the external API component area/cli Related to the CLI binary area/config Related to configuration feature New feature or request
Milestone
DefraDB v0.5.1

Comments

@fredcarle
Copy link
Collaborator

Currently, if users start developing web apps that access an instance of DefraDB directly, they will be confronted with CORS errors from the browser because the app and DefraDB will operate on different ports locally and possibly different domains publicly.

We should allow configuration of the HTTP API with a list of allowed origins.

Note: WithAllowedOrigins already exists on the API but we need to add the configuration through the CLI and config files.
@fredcarle fredcarle added feature New feature or request area/api Related to the external API component area/cli Related to the CLI binary area/config Related to configuration labels Apr 15, 2023
@fredcarle fredcarle added this to the DefraDB v0.5.1 milestone Apr 17, 2023
@orpheuslummis orpheuslummis mentioned this issue Apr 20, 2023
Closed
3 tasks
@fredcarle fredcarle self-assigned this Apr 23, 2023
@fredcarle
Copy link
Collaborator Author

Blocked by #928

@fredcarle fredcarle mentioned this issue Apr 26, 2023
Merged
4 tasks
fredcarle added a commit that referenced this issue Apr 27, 2023
@fredcarle
feat: Add allowed origins config (#1408)
6c10804 
## Relevant issue(s)

Resolves #1355 

## Description

This PR adds the option to set allowed origins for the HTTP API using
the config file or a CLI flag.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
feat: Add allowed origins config (sourcenetwork#1408)
fdddece 
## Relevant issue(s)

Resolves sourcenetwork#1355 

## Description

This PR adds the option to set allowed origins for the HTTP API using
the config file or a CLI flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/api Related to the external API component area/cli Related to the CLI binary area/config Related to configuration feature New feature or request
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

feat: Add allowed origins config fredcarle/defradb
1 participant
@fredcarle