apply feedback

sourcenetwork · Dec 16, 2022 · dea44f8 · dea44f8
1 parent c9d24c2
commit dea44f8
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/datastore/txn.go b/datastore/txn.go
@@ -46,8 +46,7 @@ type txn struct {
 
 var _ Txn = (*txn)(nil)
 
-// NOTE: rootstore temporarily set to any and should be changed when the rootstore is changed to
-// support ds.TxnDatastore
+// NewTxnFrom returns a new Txn from the rootstore.
 func NewTxnFrom(ctx context.Context, rootstore ds.TxnDatastore, readonly bool) (Txn, error) {
 	// check if our datastore natively supports iterable transaction, transactions or batching
 	if iterableTxnStore, ok := rootstore.(iterable.IterableTxnDatastore); ok {

diff --git a/db/fetcher/versioned.go b/db/fetcher/versioned.go
@@ -152,9 +152,6 @@ func (vf *VersionedFetcher) Start(ctx context.Context, txn datastore.Txn, spans
 	// create store
 	root := memory.NewDatastore(ctx)
 	vf.root = root
-	if err != nil {
-		return err
-	}
 
 	vf.store, err = datastore.NewTxnFrom(
 		ctx,

diff --git a/tests/integration/utils.go b/tests/integration/utils.go
@@ -200,6 +200,7 @@ func init() {
 		badgerInMemory = true
 		// Testing against the file system is off by default
 		badgerFile = false
+		inMemoryStore = true
 	}
 
 	if DetectDbChanges {