Remove else clause (PR request)

sourcenetwork · Apr 19, 2022 · 4468f07 · 4468f07
1 parent ced4c83
commit 4468f07
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/query/graphql/planner/sum.go b/query/graphql/planner/sum.go
@@ -147,25 +147,27 @@ func (p *Planner) getSourceField(
 					fmt.Errorf("Unable to find field description for field: %s", sourceProperty)
 			}
 			return fieldDescription, nil
-		} else {
-			parentFieldDescription, parentFieldDescriptionFound := sourceInfo.collectionDescription.GetField(sourceCollection)
-			if !parentFieldDescriptionFound {
-				return client.FieldDescription{}, fmt.Errorf(
-					"Unable to find parent field description for field: %s",
-					sourceCollection,
-				)
-			}
-			collectionDescription, err := p.getCollectionDesc(parentFieldDescription.Schema)
-			if err != nil {
-				return client.FieldDescription{}, err
-			}
-			fieldDescription, fieldDescriptionFound := collectionDescription.GetField(sourceProperty)
-			if !fieldDescriptionFound {
-				return client.FieldDescription{},
-					fmt.Errorf("Unable to find child field description for field: %s", sourceProperty)
-			}
-			return fieldDescription, nil
 		}
+
+		parentFieldDescription, parentFieldDescriptionFound := sourceInfo.collectionDescription.GetField(sourceCollection)
+		if !parentFieldDescriptionFound {
+			return client.FieldDescription{}, fmt.Errorf(
+				"Unable to find parent field description for field: %s",
+				sourceCollection,
+			)
+		}
+
+		collectionDescription, err := p.getCollectionDesc(parentFieldDescription.Schema)
+		if err != nil {
+			return client.FieldDescription{}, err
+		}
+
+		fieldDescription, fieldDescriptionFound := collectionDescription.GetField(sourceProperty)
+		if !fieldDescriptionFound {
+			return client.FieldDescription{},
+				fmt.Errorf("Unable to find child field description for field: %s", sourceProperty)
+		}
+		return fieldDescription, nil
 	}
 	return client.FieldDescription{}, fmt.Errorf("Unable to determine sum type.")
 }