Skip to content

Commit

Permalink
add documentation of the change to the data-structure
Browse files Browse the repository at this point in the history
  • Loading branch information
fredcarle committed Sep 15, 2022
1 parent 8ffafe3 commit 2eede48
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 3 additions & 0 deletions docs/data_format_changes/i610-empty-doc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Add object marker to enable return of empty docs

The object marker had previously been removed and replaces with the primary key instance type object. This reintroduces the object marker in the value instance type to allow the datastore iterator to find empty documents.
3 changes: 0 additions & 3 deletions tests/integration/query/simple/simple_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,6 @@ func TestQuerySimpleWithSomeDefaultValues(t *testing.T) {
executeTestCase(t, test)
}

// This test documents undesirable behaviour and should be altered
// with https://github.com/sourcenetwork/defradb/issues/610.
// A document with nil fields should be returned.
func TestQuerySimpleWithDefaultValue(t *testing.T) {
test := testUtils.QueryTestCase{
Description: "Simple query with default-value fields",
Expand Down

0 comments on commit 2eede48

Please sign in to comment.