indexserver: Wait for frontend to start #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should stop the logspam we see when indexserver starts up faster than the frontend pod. Change-Id: I9f6f1cd7707ad08034886d8c6e11787ad692496a
kzh
reviewed
Sep 30, 2019
| if resp.StatusCode != http.StatusOK { | ||
| return fmt.Errorf("ping: bad HTTP response status %d", resp.StatusCode) | ||
| } | ||
| body, err := ioutil.ReadAll(io.LimitReader(resp.Body, 1024)) |
There was a problem hiding this comment.
Would changing 1024 to 16 allow us to avoid doing the truncating logic below?
There was a problem hiding this comment.
yes it would! will update.
kzh
approved these changes
Sep 30, 2019
Change-Id: Ica973bd9e952c8c298cc6930b9cf7efb6402eba9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop the logspam we see when indexserver starts up faster than the
frontend pod.
Fixes https://github.com/sourcegraph/sourcegraph/issues/3371