Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batches: upsert batch change when running `src batch remote #787

Merged
merged 6 commits into from
Jun 17, 2022
Merged

batches: upsert batch change when running `src batch remote #787

merged 6 commits into from
Jun 17, 2022

Conversation

BolajiOlajide
Copy link
Contributor

Closes #780

Test plan

  • Create a server-side batch change with the command src batch remote
  • When the command is done, the batch change should be accessible via the execution link outputted in the terminal

@BolajiOlajide BolajiOlajide self-assigned this Jun 16, 2022
@BolajiOlajide BolajiOlajide changed the title upsert batch change when running `src batch remote batches: upsert batch change when running `src batch remote Jun 16, 2022
@BolajiOlajide BolajiOlajide requested a review from a team June 16, 2022 02:49
@BolajiOlajide BolajiOlajide force-pushed the bo/upsert-batch-change branch from fe98fd9 to 69b07a9 Compare June 16, 2022 17:11
courier-new
courier-new approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@courier-new courier-new left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

LawnGnome
LawnGnome approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@BolajiOlajide BolajiOlajide merged commit 96335e5 into main Jun 17, 2022
@BolajiOlajide BolajiOlajide deleted the bo/upsert-batch-change branch June 17, 2022 00:33
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@BolajiOlajide @LawnGnome
batches: upsert batch change when running `src batch remote (#787)
839d7d0 
* upsert batch change when running `src batch remote

* use batchChangeName for execution url

* update changelog

* add createBatchSpecFromRaw query

* Update CHANGELOG.md

Co-authored-by: Adam Harvey <[email protected]>

* remove redundant UpsertBatchSpecInput method

Co-authored-by: Adam Harvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LawnGnome LawnGnome LawnGnome approved these changes

@courier-new courier-new courier-new approved these changes

@eseliger eseliger eseliger approved these changes

@Piszmog Piszmog Piszmog approved these changes

Assignees

@BolajiOlajide BolajiOlajide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSBC: src batch remote preview link returns 404 if batch change did not already exist
5 participants
@BolajiOlajide @LawnGnome @courier-new @eseliger @Piszmog