Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: use grafana/regexp, matching sourcegraph/sourcegraph#30948 #694

Merged
merged 1 commit into from
Feb 11, 2022
Merged

go.mod: use grafana/regexp, matching sourcegraph/sourcegraph#30948 #694

merged 1 commit into from
Feb 11, 2022

Conversation

LawnGnome
Copy link
Contributor

I did a quick src search, and everything still looks (a) normal, and (b) garishly coloured, so I think we're good.

@LawnGnome LawnGnome requested a review from a team February 11, 2022 19:13
@LawnGnome LawnGnome self-assigned this Feb 11, 2022
eseliger
eseliger approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 are you saying you are also migrating to our errors package????? (no, you don't need to 😆)

@LawnGnome LawnGnome merged commit dcb9b8c into main Feb 11, 2022
@LawnGnome LawnGnome deleted the aharvey/grafana/regexp branch February 11, 2022 19:18
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@LawnGnome
go.mod: use grafana/regexp, matching sourcegraph/sourcegraph#30948 (#694
9f14a12 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseliger eseliger eseliger approved these changes

Assignees

@LawnGnome LawnGnome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LawnGnome @eseliger