This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
Contributor
|
❌ Problem: the label |
philipp-spiess
approved these changes
Feb 15, 2023
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 2b8e18b and 4021de7 or learn more. Open explanation
|
Contributor
|
Codenotify: Notifying subscribers in OWNERS files for diff 02157db368b9fd431aca17aa6723f6cca63ce326...fe308866564ef47f778af1d3641b31e8d2e92a0c.
|
fe30886 to
0a209d1
Compare
0a209d1 to
2b8e18b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for https://github.com/sourcegraph/sourcegraph/pull/47572
In the https://github.com/sourcegraph/sourcegraph/pull/47572 PR, we use some form logic and UI component currently placed in the insights directory (since originally, we came up with this logic for the code insights creation UI, it's still placed there).
Since in https://github.com/sourcegraph/sourcegraph/pull/47572 we need to import something enterprise (insights) in something OSS (setup wizard), we have import validation error. It's a forbidden practice to have enterprise in OSS. So, this PR just moves insight form validation logic and UI to the wildcard package.
Test plan
App preview:
Check out the client app preview documentation to learn more.