Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Form: Migrate form UI to wildcard#47677

Merged
vovakulikov merged 5 commits intomainfrom
vk/migrate-form-ui-to-wildcard
Feb 15, 2023
Merged

Form: Migrate form UI to wildcard#47677
vovakulikov merged 5 commits intomainfrom
vk/migrate-form-ui-to-wildcard

Conversation

@vovakulikov
Copy link
Contributor

@vovakulikov vovakulikov commented Feb 15, 2023

Preparation for https://github.com/sourcegraph/sourcegraph/pull/47572

In the https://github.com/sourcegraph/sourcegraph/pull/47572 PR, we use some form logic and UI component currently placed in the insights directory (since originally, we came up with this logic for the code insights creation UI, it's still placed there).

Since in https://github.com/sourcegraph/sourcegraph/pull/47572 we need to import something enterprise (insights) in something OSS (setup wizard), we have import validation error. It's a forbidden practice to have enterprise in OSS. So, this PR just moves insight form validation logic and UI to the wildcard package.

Test plan

  • Check that CI is passing

App preview:

Check out the client app preview documentation to learn more.

@github-actions
Copy link
Contributor

Problem: the label i-acknowledge-this-goes-into-the-release is absent.
👉 What to do: we're in the next Sourcegraph release code freeze period. If you are 100% sure your changes should get released or provide no risk to the release, add the label your PR with i-acknowledge-this-goes-into-the-release.

@sg-e2e-regression-test-bob
Copy link

sg-e2e-regression-test-bob commented Feb 15, 2023

Bundle size report 📦

Initial size Total size Async size Modules
0.00% (0.00 kb) -0.00% (-0.60 kb) -0.01% (-0.60 kb) 0.00% (0)

Look at the Statoscope report for a full comparison between the commits 2b8e18b and 4021de7 or learn more.

Open explanation
  • Initial size is the size of the initial bundle (the one that is loaded when you open the page)
  • Total size is the size of the initial bundle + all the async loaded chunks
  • Async size is the size of all the async loaded chunks
  • Modules is the number of modules in the initial bundle

@sourcegraph-bot
Copy link
Contributor

Codenotify: Notifying subscribers in OWNERS files for diff 02157db368b9fd431aca17aa6723f6cca63ce326...fe308866564ef47f778af1d3641b31e8d2e92a0c.

Notify File(s)
@sourcegraph/code-exploration-devs client/wildcard/src/components/Form/Form/getDefaultInputProps.ts
client/wildcard/src/components/Form/Form/hooks/index.ts
client/wildcard/src/components/Form/Form/hooks/useCheckboxes.ts
client/wildcard/src/components/Form/Form/hooks/useField.ts
client/wildcard/src/components/Form/Form/hooks/useForm.ts
client/wildcard/src/components/Form/Form/hooks/utils/get-event-value.ts
client/wildcard/src/components/Form/Form/hooks/utils/use-async-validation.ts
client/wildcard/src/components/Form/Form/hooks/validators.ts
client/wildcard/src/components/Form/Form/index.ts
client/wildcard/src/components/Form/FormGroup/FormGroup.module.scss
client/wildcard/src/components/Form/FormGroup/FormGroup.tsx
client/wildcard/src/components/Form/FormGroup/index.ts
client/wildcard/src/components/Form/index.ts
client/wildcard/src/components/index.ts

@vovakulikov vovakulikov force-pushed the vk/migrate-form-ui-to-wildcard branch from fe30886 to 0a209d1 Compare February 15, 2023 18:14
@vovakulikov vovakulikov force-pushed the vk/migrate-form-ui-to-wildcard branch from 0a209d1 to 2b8e18b Compare February 15, 2023 18:26
@vovakulikov vovakulikov merged commit 4ae685c into main Feb 15, 2023
@vovakulikov vovakulikov deleted the vk/migrate-form-ui-to-wildcard branch February 15, 2023 18:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants