This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 01eea83 and 83746c1 or learn more. Open explanation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/sourcegraph/sourcegraph/issues/47237
Preparation for https://github.com/sourcegraph/sourcegraph/pull/47572
This PR adds a new type of file hook - useControlledField. There are a few cases when we want to store the field's value, not in the form but somewhere else (like in another field store, or some external store) useControlledField doesn't bind with useForm it only adds a validation pipeline to the data; that consumer is supposed to provide.
Also, this PR fixes one small visual problem with insight creation UI (I didn't want to open yet another one-line PR for it)
Test plan
App preview:
Check out the client app preview documentation to learn more.