This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
codenotify: do not notify if it spams over 15 people #34687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 35d47fe...e877dea.
|
mrnugget
approved these changes
Apr 29, 2022
|
Let's see if this really works 🤫 (I guess I'd never know because it is no longer notifying me 😂) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
subscriber-thresholdadd in sourcegraph/codenotify#18. 15 is a number I think is reaching low-enough signal for people that are notified, happy to discuss and adjust!Test plan
n/a