Fix a bug related to textDocumentation/implementation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we emitted multiple `implementationResult` because we used the wrong `symbolInformationIDs`.
olafurpg
force-pushed
the
olafurpg/implementation-bugfix
branch
from
8a0c57f to
d30dc38
Compare
|
It's working correctly now
The root bug was that we were always emitting fresh |
|
It's difficult to see the difference from the raw dump.lsif payloads. Here are screenshots showing the gist of the difference
|
|
I'm happy to do a post-merge review if there are unaddressed comments. |
|
I merged the PR to unblock a version bump in src-cli so that we can get this fix available asap before the blog announcements. |
olafurpg
added a commit
to sourcegraph/src-cli
that referenced
this pull request
May 25, 2022
The PR we want to include sourcegraph/scip#27
olafurpg
added a commit
to sourcegraph/src-cli
that referenced
this pull request
May 25, 2022
…751) The PR we want to include sourcegraph/scip#27
scjohns
pushed a commit
to sourcegraph/src-cli
that referenced
this pull request
Apr 24, 2023
…751) The PR we want to include sourcegraph/scip#27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, doing "Find implementations" only showed one result when there were multiple results available. Now, all available results should be shown after this fix.
Opening this as a draft since it's still not working 100% and I'm gonna continue with this PR tomorrow.
Test plan
See newly added snapshot tests. I'm also manually testing this change by uploading the generated dump.lsif to Sourcegraph here https://sourcegraph.com/github.com/sourcegraph/scip-typescript@34337f2fa29d3a83c71814458d19741ae4f21db9/-/blob/snapshots/input/syntax/src/inheritance2.ts?L2:3&subtree=true#tab=implementations_typescript