This repository has been archived by the owner on May 29, 2018. It is now read-only.
Add fields needed for search pagination #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM. We'll want to review this in a higher level context as well. |
This is the beginning of a multi-step plan to breakup the monolithic Search.Search method. There will be a specific search method for each result type that is accessible though Search.Search, and as a result Search.Search is now deprecated and will be removed when it is no longer needed. There is also a specific options type for each Search method, but they may be unified in the future if appropriate.
renfredxh
force-pushed
the
nodb-def-pagination
branch
from
4aa7220
to
3b524cb
Compare
| @@ -2481,12 +2498,28 @@ service RepoTree { | |||
| // API. | |||
| service Search { | |||
| // Search searches the full index. | |||
| // This method is deprecated (use one of the more specific | |||
| // search methods below) | |||
There was a problem hiding this comment.
[hound-mode] Spaces vs. tabs issue here. [/hound-mode] :P
| @@ -2481,12 +2498,28 @@ service RepoTree { | |||
| // API. | |||
| service Search { | |||
| // Search searches the full index. | |||
| // This method is deprecated (use one of the more specific | |||
| // search methods below) | |||
There was a problem hiding this comment.
Let's use the Go style for deprecation. Make the first word of the sentence "Deprecated". E.g.:
// Deprecated: use one of the more specific search methods below.
|
One comment about deprecation convention. Otherwise LGTM. |
renfredxh
added a commit
that referenced
this pull request
Oct 6, 2015
Add fields needed for search pagination
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a few fields and methods that will make pagination for search easier: