extract initContainers into kustomization #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedeportivo
requested review from
keegancsmith,
beyang,
emidoots and
ggilmore
keegancsmith
approved these changes
Feb 28, 2020
uwedeportivo
added a commit
that referenced
this pull request
Feb 29, 2020
) * switch away from user 0 (root) and delete unnecessary cluster role binding * pgsql data dir tweak * avoid chown when already correct * extract initContainers into kustomization (#537) * migrate doc * buildkite checks accommodate kustomize * kubectl version is not working * asas !!!!! * migrate doc specifies kubectl version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the initContainers into a kustomization, so once the migration is done through
the initContainers don't pollute the base anymore.
I prefer this over having the initContainers inside base always getting executed (with no clear timeline when to remove them). This way we document that once this is committed they have to migrate once and then they can run normal and ignore this overlay.
And new installations can ignore this altogether.
What do you guys think ?
I'm also thinking of removing the custom ClusterRoles and using built in ones.
Then the only remaining items are some configmap alterations.