Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only scrape metrics of containers within sourcegraph namespace #2969

Merged
merged 3 commits into from
May 18, 2021

Conversation

daxmc99
Copy link
Contributor

@daxmc99 daxmc99 commented May 18, 2021

Namespaced Prometheus overlays should only scrape containers within its namespace for cAdvisor metrics.
This should prevent excessive metrics that takedown Prometheus

Checklist

@daxmc99 daxmc99 requested a review from a team May 18, 2021 01:01
@daxmc99 daxmc99 enabled auto-merge (squash) May 18, 2021 23:01
@daxmc99 daxmc99 disabled auto-merge May 18, 2021 23:01
@daxmc99 daxmc99 changed the title Ensure that Prometheus only scraps metrics of containers within Sourcegraph namespace Only scrape metrics of containers within sourcegraph namespace May 18, 2021
@daxmc99 daxmc99 enabled auto-merge (squash) May 18, 2021 23:01
@daxmc99 daxmc99 merged commit 698797c into master May 18, 2021
@daxmc99 daxmc99 deleted the dax/namespaced_overlay_prometheus branch May 18, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant