Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add limits for ephemeral storage #1852

Merged
merged 4 commits into from
Feb 18, 2021
Merged

add limits for ephemeral storage #1852

merged 4 commits into from
Feb 18, 2021

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Feb 16, 2021

These initial figures are speculative at best, and customers would need to set these themselves in my cases I imagine depending on deployment size.

These change also doesn't modify anything in the configure directory.

fixes https://github.com/sourcegraph/sourcegraph/issues/9604

@davejrt davejrt requested a review from a team February 16, 2021 12:36
Copy link
Contributor

@uwedeportivo uwedeportivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like reasonable values. Ideally anything that requires more would be using an explicit volume mount in our app.

@davejrt davejrt enabled auto-merge (squash) February 18, 2021 15:26
@davejrt davejrt merged commit 731e3dc into master Feb 18, 2021
@davejrt davejrt deleted the dt/ephemeral_limits branch February 18, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent services from running out of ephemeral storage space and being evicted
2 participants