Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cody://repository isn't able to resolve in cody chat #6885

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bahrmichael
Copy link
Contributor

Fixes SRCH-1592

Currently only for cody://repository. Other fields might be affected, too. Will check for them if the approach taken here is okay.

Test plan

Manual testing, it works now:

Screenshot 2025-01-30 at 12 59 29

Copy link
Contributor

@vovakulikov vovakulikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because I don't think it breaks anything, but I'm not sure that I understand how it was broken in the first place. The initial context is used in prompt hydration only in the case of Cody Web, VSCode and JB clients should mock their VSCode-like API so we get context info from that API and not context.initialContext.

@bahrmichael
Copy link
Contributor Author

bahrmichael commented Jan 31, 2025

VSCode and JB clients should mock their VSCode-like API so we get context info from that API and not context.initialContext

I was only able to debug via Cody Web, and assumed that JB/VSCode would take a similar approach. Could you help point me to the place where that behavior diverges?

Just tested this again with local VSCode, and it doesn't work at all :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants