This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 136
Adds InfluxDB store. #99
Merged
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
7a77805
adds empty time value validation
chris-ramon ad72e8d
adds initial support for influxdb store
chris-ramon 255c2f3
updates to reuse code from examples/cmd/webapp
chris-ramon 6d805b2
manuall install deps
chris-ramon 4e1dd54
updates to correct paths
chris-ramon 8770314
adds Collect & Trace implementation
chris-ramon ca50fa5
cleans up influxdb example
chris-ramon 7d6fb1b
adds Traces implementation & cleanups InfluxDBStore
chris-ramon 92361fe
fixes naming clash
chris-ramon 750cbb1
updates to more consistent func names
chris-ramon 56cab8a
improvements on Traces implementation
chris-ramon 9200ceb
use map literals instead for readability
chris-ramon 1fb42e1
use default point precision 'ms' & set utc time
chris-ramon 9b93faa
typo
chris-ramon 58a6762
updates NewInfluxDBStore param signature, using struct instead for co…
chris-ramon 6350b82
improves code style
chris-ramon ff0908d
improves strategy for replace existing spans on DB
chris-ramon 4f6636d
improves root span checking
chris-ramon 40233de
fields might contain empty values
chris-ramon 38edc7b
temp fix for frontend hanging
chris-ramon c42412b
typo
chris-ramon e4435cf
Revert "temp fix for frontend hanging" - Lasting fix on 7a778051de9c5…
chris-ramon 7c8f13f
updates to preserve existing span fields
chris-ramon f080311
use ID's method instead of its implementation
chris-ramon 5a5b73e
set all other fields diff than Name too
chris-ramon d79b264
improvements on span annotations updating
chris-ramon ab57107
handles potential closing errors
chris-ramon b4a8ae4
captures potential closing error and logs it
chris-ramon 6e47b28
adds trace pagination related todo
chris-ramon ddebe98
updates to handle multiple row values & update docs
chris-ramon e23224c
docs improvements on InfluxDBStore.Collect method
chris-ramon c4a97ba
adds missing whitespace
chris-ramon 6d10ff7
adds support to save `schemas` field to spans measurement
chris-ramon 1ad279d
Revert "adds empty time value validation"
chris-ramon dc13fa8
adds sorting related improvements
chris-ramon 2f2bc85
improves comments for `InfluxDBStore`
chris-ramon 4123a95
updates influxdb related paths; fixes introduced on v0.10
chris-ramon f0a959d
adds support for auth to `InfluxDBStore.server`
chris-ramon d0cf9fb
typo and fit comments into 80-char-width
chris-ramon d589fcb
updates to keep 80-chars code width limit
chris-ramon 745ea49
Revert "updates to keep 80-chars code width limit"
chris-ramon 77130ee
adds mode(test, release) support for InfluxDBStore
chris-ramon 5db3789
adds InfluxDBStore tests
chris-ramon 49f63e5
removes httptrace dependency to avoid cyclic dependencies
chris-ramon 2d762fe
adds test for InfluxDBStore.Traces()
chris-ramon f056451
improvements on comments, unnecessary code & codestyle
chris-ramon 4a4b359
adds default retention policy support
chris-ramon 62b5c69
improves comments readability & adds a low priority TODO
chris-ramon a7fb78f
support to add sub-traces to it's trace parent
chris-ramon d4354ee
clean-up TestInfluxDBStore & adds TestFindTraceParent
chris-ramon 7024adb
code readability improvements
chris-ramon ef7a19a
disables reporting to m.influxdb.com
chris-ramon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "updates to keep 80-chars code width limit"
This reverts commit d589fcb.
- Loading branch information
commit 745ea497a0f8ace6359a37417c5c1f15a8ee800c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine for now (limiting to just
in.tracesPerPage
) but long-term we'll need a way to provide an offset. i.e. to fetch the second page of results. I wonder if InfluxDB can do this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can use offset to provide pagination.