Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

InfluxDBStore: do not use deprecated "IF NOT EXISTS" condition when creating DB #159

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- [#157](https://github.com/sourcegraph/appdash/pull/157) Added proper point-batching support to InfluxDBStore.
- [#157](https://github.com/sourcegraph/appdash/pull/157) Changed `ChunkedCollector.FlushTimeout` default from 50ms to 2s.
- [#158](https://github.com/sourcegraph/appdash/pull/158) Made InfluxDBStore use Continuous Queries so the Dashboard is very responsive.
- [#159](https://github.com/sourcegraph/appdash/pull/159) InfluxDBStore no longer uses the deprecated `IF NOT EXISTS` condition when creating the DB.
- Apr 15, 2016 - **Breaking Changes!**
- [#136](https://github.com/sourcegraph/appdash/pull/136) Users must now call `Recorder.Finish` when finished recording, or else data will not be collected.
- [#136](https://github.com/sourcegraph/appdash/pull/136) AggregateStore is removed in favor of InfluxDBStore, which is also embeddable, and is generally faster and more reliable. Refer to the [cmd/webapp-influxdb](https://github.com/sourcegraph/appdash/blob/master/examples/cmd/webapp-influxdb/main.go#L50) for further information on how to migrate to `InfluxDBStore`, or [read more about why this change was made](https://github.com/sourcegraph/appdash/issues/137).
Expand Down
2 changes: 1 addition & 1 deletion influxdb_store.go
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ func (in *InfluxDBStore) Close() error {
}

func (in *InfluxDBStore) createDBIfNotExists() error {
q := fmt.Sprintf("CREATE DATABASE IF NOT EXISTS %s", in.dbName)
q := fmt.Sprintf("CREATE DATABASE %s", in.dbName)

// If a default retention policy is provided, it's used to extend the query in order to create the database with
// a default retention policy.
Expand Down