Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

InfluxDBStore: use Continuous Queries to make the Dashboard very responsive #158

Closed
wants to merge 2 commits into from

Conversation

emidoots
Copy link
Member

@emidoots emidoots commented Apr 27, 2016

This change uses Continuous Queries to downsample our span data in such a way as to make the Dashboard page very responsive even when there are a large number of spans being stored.

Fixes #141

Based on #157 for simplicity.

@keegancsmith
Copy link
Member

Very fancy! InfluxDB looks pretty damn cool. Two questions:

  • Can this change have any test coverage (or is it covered by existing tests)
  • What happens if no events happen in a minute? (ie does everything work as expected)

Otherwise code and idea LGTM

@emidoots emidoots force-pushed the sg/5-influx-batching branch from 3417fb2 to c9dba40 Compare April 27, 2016 18:42
…onsive

This change uses Continuous Queries to downsample our span data in such
a way as to make the Dashboard page very responsive even when there are
a large number of spans being stored.

Fixes #141
@emidoots emidoots force-pushed the sg/6-influx-dashboard-perf branch from b889733 to 5f0b968 Compare April 27, 2016 18:44
@emidoots
Copy link
Member Author

These are good questions.

Can this change have any test coverage (or is it covered by existing tests)

Currently there are no tests for the Aggregate method at all, and I agree we should add them. For this I've filed #160 in an effort to not block this PR. I have done extensive testing locally and everything does work, so I'm confident this is a clear improvement. Let's invest in these tests soon.

What happens if no events happen in a minute? (ie does everything work as expected)

I did test this case locally as well, and can confirm it does. In specific, InfluxDB handles any query on a non-existing measurement (table) by returning no results, thus hitting this case https://github.com/sourcegraph/appdash/pull/158/files#diff-b7da646763ca1f5622f8d108c536ce86R295

@emidoots
Copy link
Member Author

Merged into master.

@emidoots emidoots closed this Apr 27, 2016
@emidoots emidoots deleted the sg/6-influx-dashboard-perf branch April 27, 2016 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants